[AutoDev] FLOW-2251 atlascode: AxiosError:RovoDevFeedbackManager.submitFeedback - #1888
Open
atlassian[bot] wants to merge 1 commit into
Open
Conversation
Replace RovoDevTelemetryProvider.logError() with Logger.warn() in RovoDevFeedbackManager.submitFeedback to prevent feedback submission failures (network errors, non-2xx responses) from being reported to Sentry and triggering SLO errors. These failures are non-critical and expected in transient failure scenarios. Co-authored-by: Evan Cook <ecook@atlassian.com>
atlassian
Bot
requested review from
Blastoplex,
amarg-at,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
cindy-atl,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
mattcolman,
sdzh-atlassian and
teg-atlassian
as code owners
June 30, 2026 04:21
|
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue where AxiosError in RovoDevFeedbackManager.submitFeedback was being sent to Sentry and causing SLO errors. Instead of treating these errors as critical, feedback submission failures due to network errors or non-2xx HTTP responses are now logged as warnings, reflecting their transient and expected nature.
Key changes:
This improves reliability by preventing non-critical feedback submission errors from triggering error tracking and alerting systems unnecessarily, while still informing users of submission issues.
Rovo Dev code review: Rovo Dev couldn't review this pull request
Rovo Dev does not review pull requests created by bot accounts.